Skip to content

Commit

Permalink
consider review comments
Browse files Browse the repository at this point in the history
thanks to [at]kayoub5 for the finds.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Michael Hahn <[email protected]>
  • Loading branch information
andlaus committed Mar 1, 2024
1 parent 6f1e172 commit 7b13385
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions odxtools/compumethods/compuscale.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from typing import List, Optional
from xml.etree import ElementTree

from ..exceptions import odxraise
from ..odxlink import OdxDocFragment
from ..odxtypes import AtomicOdxType, DataType
from ..utils import create_description_from_et
Expand Down Expand Up @@ -81,8 +80,8 @@ def from_et(et_element: ElementTree.Element, doc_frags: List[OdxDocFragment], *,
def applies(self, internal_value: AtomicOdxType) -> bool:

if self.lower_limit is None and self.upper_limit is None:
odxraise("No limits specified for compu scale")
return False
# Everything is allowed: No limits have been specified
return True
elif self.upper_limit is None:
# no upper limit has been specified. the spec says that
# the value specified by the lower limit is the only one
Expand Down

0 comments on commit 7b13385

Please sign in to comment.