Followup fixes #170
Merged
Followup fixes #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- better type checking - add the `keys()`, `values()` and `items()` methods. (this makes `NamedItemList` objects more similar to normal dictionaries. Note that using the items() function is pretty slow.) - get rid of the `_typed_dict` attribute. (we now use the untyped `__dict__` plus separate lists for the item names and values...) - ensure that item names are valid before extending the list. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
this ensures that only legal values are specified at runtime. thanks to [at]kayoub5 for naggig about this. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
kayoub5
reviewed
Aug 2, 2023
kayoub5
reviewed
Aug 2, 2023
kayoub5
reviewed
Aug 2, 2023
kayoub5
reviewed
Aug 2, 2023
kayoub5
reviewed
Aug 2, 2023
kayoub5
reviewed
Aug 2, 2023
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
thanks to [at]kayoub5 for the suggestion!. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]> Co-authored-by: Ayoub Kaanich <[email protected]>
kayoub5
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are an extended version of some of the "lateral" fixes that emerged during the review of #168. in particular, I fixed a few issues with
NamedItemList:__iter__()method is still not properly annotated, because doing so currently leads to a lot of typechecking errors.keys(),values()anditems()methods. This makesNamedItemListobjects more similar to normal dictionaries. Be aware that.items()is currently quite slow._typed_dictattribute. We now use the untyped__dict__plus separate lists for the item names and values...NamedItemListAndreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information