Refactor decoding, part 1 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the purpose of this is to make the decoding routine a bit more transparent and slightly more performant: instead of copying the blob to be decoded, we now keep this constant and have an `origin_position` attribute besides `cursor_position`. The `origin_position` is the position within the blob to be decoded to which relative positions of positionable parameters are ancored to. This allows objects like structures, to just modify the origin position of the decode state instead of creating a completely new one. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Katja Köhler <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Katja Köhler <[email protected]>
kayoub5
reviewed
Feb 7, 2024
kayoub5
reviewed
Feb 7, 2024
kayoub5
approved these changes
Feb 8, 2024
|
thanks for the review @kayoub5 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of a mini series to refactor the decoding code of odxtools. In this PR, we refactor the
DecodeStateclass with the aim of not having to create copies during the decoding process:cursor_positionandorigin_positionare introduced. The former points to the first undecoded byte whilst the latter points to the byte to which relative positions given by the BYTE-POSITION tag refer to.parameter_valuesproperty is removed. Instead, the parameter values are kept as local variables in the respective decoding functions.length_keysandtable_keysattributes are introduced, to keep track of inter-parameter dependenciesnote that the "do not create copies" aim is not yet fully reached after this PR, but it will be at the end of this PR series...
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information