fix the code computing value inheritance #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andlaus
force-pushed
the
value_inheritance_fixes
branch
from
08bf1f4
to
abd9332
Compare
the new version hopefully fully adheres to the specification, the previous version had some issues with the priority of ECU shared data parents, and conflict handling of inherited objects did not fully match the specification: - the "not inherited" objects where not considered while populating the list, causing the function to produce undefined results if inheritance conflicts were solved using this mechanism. - inheritance conflicts where generally not detected. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
andlaus
force-pushed
the
value_inheritance_fixes
branch
from
abd9332
to
88f7d15
Compare
|
@kayoub5: can you have a brief look at this / check that your files continue to work? |
|
Just a heads up: barring vetos, I'll merge this early next week. |
|
@kayoub5: do you see any issues with this one? if not, I'd like to merge it tomorrow... |
I don't see issues, but I don't have time to test it with the PDX files I have |
okay. I think the risks of this are quite small, so let's merge and fix the fallout later (if any). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that the ODX specification for value inheritance slightly differed from the version which was implemented by odxtools:
This PR fixes these issues and we now hopefully fully adhere to the specification. (I doubt that it did matter for many datasets, though. For the ones I have access to, it didn't.)
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information