Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more linters happy #277

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Make more linters happy #277

merged 3 commits into from
Mar 4, 2024

Commits on Mar 4, 2024

  1. make flake8 happy 

    this supposes that it is run using

```
flake8 --ignore E124,E125,E126,E131,E501,F541,W503,W504 odxtools tests
```

Note that flake8 does not support configuration using
`pyproject.toml`, so setting these parameters by default would require
a new `.flake8` file in the repository. That said, IMO providing a
pre-packaged config for `flake8` is mildly undesireable anyway because
I think `flake8` should continue not be run as part of the CI system
(mainly because it plays style police and it clashes with our yapf
output but also because it would further raise the burden for getting
pull requests merged) and thus the file would almost certainly bitrot.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Christian Hackenbeck <[email protected]>
    @andlaus
    andlaus committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    97f9edf View commit details
    Browse the repository at this point in the history

  2. fix a few issues flagged by pytype and pyright 

    pytype in particular seems to be missing a few features and is
glacially slow...

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Christian Hackenbeck <[email protected]>
    @andlaus
    andlaus committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8b37dc4 View commit details
    Browse the repository at this point in the history

  3. consider review comments 

    as usual, thanks to [at]kayoub5 for the finds.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Christian Hackenbeck <[email protected]>
    @andlaus
    andlaus committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    71833ee View commit details
    Browse the repository at this point in the history