Skip to content

Commit

Permalink
Use proposed solution for 'AttributeError' instead of README approach…
Browse files Browse the repository at this point in the history
… for best user experience. (fix martomo#163, fix martomo#174)
  • Loading branch information
martomo committed Jan 7, 2018
1 parent 920feb7 commit f631db4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
8 changes: 0 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,14 +301,6 @@ Some systems do not include specific modules which are required by this package,

Configure the `python_path` setting to the path of your Python installation on your system which is either newer or has all required modules. For example: `"python_path" : "/usr/lib/python2.7"`.

#### How to solve `AttributeError`?
Upon updating Sublime Text, there were reports that packages stopped working, due to the following error:
```
AttributeError: 'module' object has no attribute 'parse'
```
In case you are experiencing this error with SublimeTextXdebug, there is a [solution](https://forum.sublimetext.com/t/module-error-when-running-a-plugin/23611/5) that requires you to uninstall Package Control and reinstall it. Before doing so be sure to first create a backup of your *Packages/User/Package Control.sublime-settings*.
As it might happen that on uninstall Package Control moves all the packages in *Packages/User/Package Control.sublime-settings* to `ignored_packages` in *Packages/User/Preferences.sublime-settings*, resulting none of the packages to work due to being unmanaged and disabled.

#### What to do when you experience any issues?
First check following _possible_ solutions that could resolve any issues:

Expand Down
6 changes: 3 additions & 3 deletions xdebug/helper/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"""

import base64
import urllib.parse
from urllib.parse import unquote, quote
from collections import OrderedDict


Expand All @@ -16,11 +16,11 @@ def modulename():


def url_decode(uri):
return urllib.parse.unquote(uri)
return unquote(uri)


def url_encode(uri):
return urllib.parse.quote(uri)
return quote(uri)


def new_dictionary():
Expand Down

0 comments on commit f631db4

Please sign in to comment.