-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the icon collection for Helm plugin #1917
base: master
Are you sure you want to change the base?
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: bhushan354 <[email protected]>
@bhushan354 Thank you for your contribution! Please add it as an agenda item to the meeting minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when the site visitor is using light mode?
|
@leecalcote I’m still working on it. Also, I wanted to ask why the changes I made to the code, like the UI updates, aren't reflecting on localhost. |
i am having this problem from many days |
Exclude —incremental and —livereload from your build command. |
Meshery.io.mp4@leecalcote I've excluded --incremental and --livereload from the build command, but the issue is still persisting. |
@leecalcote its working now and updating according to local changes , thanks for the help !! |
@bhushan354 any updates? |
@sudhanshutech someone has already added the helm plugin extension |
Description
This PR fixes #
#1915
Notes for Reviewers
I have implemented the basic structure necessary to add the new extension on the meshery.io/extensions/ page. However, the content displayed in the pop-up still needs to be updated, and the light theme also requires modifications.
Signed commits