Add First Heard and Last Heard times to node details #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add the first heard as well? I added it to node info recently and it has been populating for a while |
|
If you share your location from your phone it should get time |
72A12F4E
changed the title
72A12F4E
force-pushed
the
last-heard-node-detail
branch
from
a16ad9a
to
a08d3aa
Compare
|
@garthvh hows this? |
72A12F4E
force-pushed
the
last-heard-node-detail
branch
from
a08d3aa
to
e485176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the last heard date to the node details screen. Unfortunately, it seems much of this data is buggy for me, and I have several nodes with lastHeard dates on Jan 1 1970, so I can't really validate that the change works on the happy path.