Fix opentelemetry adapter #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshyv
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
dineshyv
changed the title
ashwinb
reviewed
Nov 23, 2024
| @@ -282,6 +211,19 @@ async def endpoint(request: Request, **kwargs): | |||
| return endpoint | |||
|
|
|||
|
|
|||
| class TracingMiddleware: | |||
ashwinb
reviewed
Nov 23, 2024
| @@ -8,5 +8,5 @@ | |||
|
|
|||
|
|
|||
| class OpenTelemetryConfig(BaseModel): | |||
There was a problem hiding this comment.
can you add a sample_run_config() here while you are at it. it will be useful some day.
ashwinb
reviewed
Nov 23, 2024
| agent_port=self.config.jaeger_port, | ||
| provider = TracerProvider(resource=resource) | ||
| trace.set_tracer_provider(provider) | ||
| otlp_exporter = OTLPSpanExporter( |
There was a problem hiding this comment.
I think it would be really useful to dump what this entity is ending on the wire to Jaeger as we talked about. If we can elide it, we reduce our dependency on all of these libraries too. The protocol is open.
SLR722
pushed a commit
that referenced
this pull request
Nov 27, 2024
# What does this PR do? This PR fixes some of the issues with our telemetry setup to enable logs to be delivered to opentelemetry and jaeger. Main fixes 1) Updates the open telemetry provider to use the latest oltp exports instead of deprected ones. 2) Adds a tracing middleware, which injects traces into each HTTP request that the server recieves and this is going to be the root trace. Previously, we did this in the create_dynamic_route method, which is actually not the actual exectuion flow, but more of a config and this causes the traces to end prematurely. Through middleware, we plugin the trace start and end at the right location. 3) We manage our own methods to create traces and spans and this does not fit well with Opentelemetry SDK since it does not support provide a way to take in traces and spans that are already created. it expects us to use the SDK to create them. For now, I have a hacky approach of just maintaining a map from our internal telemetry objects to the open telemetry specfic ones. This is not the ideal solution. I will explore other ways to get around this issue. for now, to have something that works, i am going to keep this as is. Addresses: #509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes some of the issues with our telemetry setup to enable logs to be delivered to opentelemetry and jaeger. Main fixes
Addresses: #509
Test Plan
llama stack run /Users/dineshyv/.llama/distributions/llamastack-together/together-run.yaml
PYTHONPATH=. python -m examples.agents.rag_with_memory_bank localhost 5000