-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session id to traces and a new export endpoint to export traces for a session #525
base: main
Are you sure you want to change the base?
Conversation
|
||
@webmethod(route="/telemetry/get-traces-for-session", method="POST") | ||
async def get_traces_for_session( | ||
self, session_id: str, lookback: str = "1h", limit: int = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions:
-
Should we make
lookback
window to be int in second or smt? What does thelimit
mean? -
Is the
session_id
specific to theAgent
? Wondering how do we deal with llama-stack apps built with inference/chat_completion API call only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The argument for lookback is actually a string for jaeger as well. I think its easier to specify the window using 1h or 5s instead of int.
- If its not part of a session, we should be able to get the trace using just the trace id. We already have a endpoint for that, but not implemented for open telemetry. I can add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syned offline. We will be adding traces at the individial API level rather than focusing just on the agent.
bdb4c1a
to
aa34573
Compare
What does this PR do?
Addresses #509
Test Plan
Output of export: https://pastebin.com/Y2mxMQXR