Donation Flairs Improvements #3043
Open
+164
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
requested changes
Nov 26, 2024
| @@ -50,6 +51,7 @@ export default class RecentListens extends React.Component< | |||
| </div> | |||
| <div className="row"> | |||
| <div className="col-md-4 col-md-push-8"> | |||
| <FlairsExplanationButton /> | |||
There was a problem hiding this comment.
I think on this page the link would be better placed under the recent donors card
| @@ -494,6 +495,7 @@ export default function Listen() { | |||
| /> | |||
| )} | |||
| </div> | |||
| <FlairsExplanationButton /> | |||
There was a problem hiding this comment.
Same as the recent listens, on this page i would suggest placing the link in UserSocialNetwork component instead, but in-between both of the card components that it renders.
I think that has the best noticeability vs. annoyance ratio :p
| @@ -648,6 +649,7 @@ export default function UserFeedPage() { | |||
| )} | |||
| </div> | |||
| <div className="col-md-offset-1 col-md-4"> | |||
| <FlairsExplanationButton /> | |||
There was a problem hiding this comment.
With my suggested change to put the link in UserSocialNetwork this will need to be removed
| Ready to support us? <Link to="/donate/">Donate here</Link> or{" "} | ||
| <Link to="/donors/">view our donors</Link> | ||
| . | ||
| <br /> |
There was a problem hiding this comment.
Using paragraphs > using <br> elements :p
Suggested change
| <br /> | |
| <p> | |
| These are special flairs that show our appreciation for donations! | |
| </p> | |
| <p> | |
| Support ListenBrainz with a donation and unlock these effects on | |
| your username. Each $5 donation unlocks flairs for a month, and | |
| larger donations extend your access time. ✨ | |
| </p> | |
| <p> | |
| You can choose your flair from a selection in the{" "} | |
| <Link to="/settings/">user settings page.</Link> | |
| </p> | |
| <p> | |
| Ready to support us? <Link to="/donate/">Donate here</Link> or{" "} | |
| <Link to="/donors/">see who else is supporting</Link>. | |
| </p> |
| Ready to support us? <Link to="/donate/">Donate here</Link> or{" "} | ||
| <Link to="/donors/">view our donors</Link> | ||
| . | ||
| <br /> |
There was a problem hiding this comment.
Laying it even thicker
Suggested change
| <br /> | |
| These are{" "} | |
| <span className="flair sliced strong" data-text="special flairs"> | |
| special flairs | |
| </span>{" "} | |
| to show our appreciation for your donations! |
|
Sorry,m some of those code suggestions are on the wrong line.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
If we want to backfill the donor's data, I've written this function https://gist.github.com/anshg1214/48a24f5fa50d284f178e2eab2d31ba16.