Compute valid top-level MARC record leader. #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcXmlEncoder acts as a wrapper. It makes use of Marc21Encoder and Marc21Decoder to ensure proper MARCXML, especially regarding the leader. Also - in contrast to MarcXmlEncoder - the record ID (field 001) is mandatory. The outer class is responsible for routing the stream into the appropriate pipe, the inner class contains the actual (previous) implementation. Co-authored-by: Pascal Christoph <[email protected]>
Closed
dr0i
approved these changes
Jun 20, 2024
Apparently not... I'm pretty sure this used to be the case. Changed it manually now. UPDATE: Maybe it's because I forgot to select the correct base branch when creating the pull request? I only fixed it afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #524.
See also previous discussion in #531.
Base branch will be changed automatically once #538 is merged.