Add option 'validateLeader' #572
Conversation
dr0i
force-pushed
the
567-addEncodeMarc21ValidationAsOptional
branch
from
74ef168 to
922dd0d
Compare
|
@TobiasNx I haven't deployed to playground dev. I think you can check out this branch and test it easily locally? |
| marc21Encoder.setValidateLeader(false); | ||
|
|
||
| marc21Encoder.startRecord(""); | ||
| marc21Encoder.literal(LEADER_ENTITY, BAD_LEADER ); |
There was a problem hiding this comment.
I had inserted the extra line on purpose to separate the setting of attributes of the class vs. using the interface feeding the document - but it looks ugly. I've removed now the empty line.
There was a problem hiding this comment.
Too bad, it made sense (exactly for the reason you mentioned). I was talking about the extra blanks around BAD_LEADER.
There was a problem hiding this comment.
Ah - good :) This explains why you said "whitespace", not "empty line" - was wondering myself why you were so (uncommonly) imprecise.
|
+1 seems to work, leader is not tested anymore if I use |
dr0i
force-pushed
the
567-addEncodeMarc21ValidationAsOptional
branch
from
922dd0d to
06a62ff
Compare
Complements 06a62ff. Thx @blackwinter.
Complements 06a62ff. Thx @blackwinter.
Resolves #567.