Improve Exception messages when working on "leader" #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:metafacture/metafacture-core
Add leader hint to error message
dr0i
reviewed
Nov 19, 2024
metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/Marc21Encoder.java
Outdated
Show resolved
Hide resolved
dr0i
requested changes
Nov 19, 2024
TobiasNx
commented
Nov 19, 2024
| @@ -278,7 +278,7 @@ private void requireValidCode(final char code, final char[] validCodes) { | |||
| return; | |||
| } | |||
| } | |||
| throw new FormatException("invalid code '" + code + "'; allowed codes are: " + Arrays.toString(validCodes)); | |||
| throw new FormatException("invalid code in leader'" + code + "'; allowed codes are: " + Arrays.toString(validCodes)); | |||
There was a problem hiding this comment.
@dr0i is it possible to add the info about the leader element? like this:
Suggested change
| throw new FormatException("invalid code in leader'" + code + "'; allowed codes are: " + Arrays.toString(validCodes)); | |
| throw new FormatException("invalid code in leader literal literal'" + name + code + "'; allowed codes are: " + Arrays.toString(validCodes)); |
There was a problem hiding this comment.
You've proposed to add literal literal as message. And a variable name which is not declared in the method nor globally (meaning: you cannot use it here).
What you probably meant to output was something like e.g. TYPE_OF_CONTROL_CODES or ENCODING_LEVEL_CODES so that a librarian knows what leader position is wrong? We could do this, but have to pass this information somehow into the method via a parameter.
…/Marc21Encoder.java
dr0i
changed the title
|
Note: don't use titles like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add leader hint to error message. See #573
Open adjust the message:
metafacture-core/metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/Marc21Encoder.java
Line 160 in eab57cd
metafacture-core/metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/Marc21Encoder.java
Line 208 in eab57cd
Also it would be greate to hint, which leader position or position name which is wrong.