Merge metafacture-fix. #586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jens Wille <[email protected]>
- add tests - add to README
This was overriding every defaultValue, but maps should have the possibility to have different default values.
Fixes the "Failed to load class org.slf4j.impl.StaticLoggerBinder" message when building.
Implementation against further tests from #415 (comment). - adapt some falsely Fix - reuse test file "hcrt.ttl" - one test tagged as "todo" because it needs introduction of new parameter - reformat hcrt.ttl
- enable integration test - add test See #415.
- update README - integrate lookup_rdf() into lookup() - rename target_language to select_language (complements b49445d) - remove comments in integrations test.fix for these are accounted to
This tests a redirected URL handled in org.metafacture.metafix.maps.RdfMap#read.
Tweak test: add blank inserted by `paste` as default `join_char`
Add integration test for #278
…ogrammaticallyAddedValues Fix issues caused by incomplete value paths
This reverts commit 19051fb.
This reverts commit 00838b6.
The generated start script for Windows consists of a huge classpath. This classpath was too long, resulting in an error when executing the start script. Using wildcard to include libraries shortens the classpath so that now error occurs when executing the start script.
Co-authored-by: Jens Wille <[email protected]>
Gradle would produce the following error on Windows (while Linux is not affected): "Cannot access input property 'classpath' of task ':metafix-runner:startScripts'. Accessing unreadable inputs or outputs is not supported. Declare the task as untracked by using Task.doNotTrackState(). For more information, please refer to https://docs.gradle.org/8.10.2/userguide/incremental_build.html#sec:disable-state-tracking in the Gradle documentation."
…hub.com:metafacture/metafacture-fix
- add test - update README
Co-authored-by: Jens Wille <[email protected]>
Co-authored-by: Jens Wille <[email protected]>
Complements 9014b01.
Ignore old value's path in `copy_field` Fix function.
Enables java logging. The log level can be changed by setting a variable. Set and run like this: export JAVA_OPTS="-Dorg.metafacture.metafix.logLevel=DEBUG"; ./gradlew installDist; cd metafix-runner/build/install/metafix-runner; bin/metafix-runner $pathTo.flux Note that you cannot use `./gradlew :metafix-runner:run ...` as setting the log level only works within the distribution. Co-authored-by: Jens Wille <[email protected]>
Optionally specify limit for number of entities in a record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported metafacture/metafacture-fix@b254549.
Resolves #577 (details outlined here).