Log metadata diffs on upserts #208
Open
+73
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 72.46% 72.27% -0.20%
==========================================
Files 10 10
Lines 810 844 +34
==========================================
+ Hits 587 610 +23
- Misses 163 169 +6
- Partials 60 65 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ScottGarman
force-pushed
the
log-upsert-diffs
branch
3 times, most recently
from
f3e32ed
to
d8d36e3
Compare
Before performing an upsert, log the differences between the existing metadata and the new metadata. This will help us understand what is happening when we see unexpected changes in the metadata.
ScottGarman
force-pushed
the
log-upsert-diffs
branch
from
d8d36e3
to
c10f7a0
Compare
mmlb
approved these changes
Feb 15, 2024
|
|
||
| existingMetadata, err := models.FindInstanceMetadatum(c.Request.Context(), r.DB, instanceID) | ||
| if err != nil && !errors.Is(err, sql.ErrNoRows) { | ||
| r.Logger.Sugar().Info("Upsert metadata diff for instance ", instanceID, ": this is the first metadata for this instance (sql.ErrNoRows)") |
There was a problem hiding this comment.
I suspect this is going to be really noisy and not very helpful to have to weed out, doesn't feel necessary to log this condition.
| } | ||
|
|
||
| if existingMetadata == nil { | ||
| r.Logger.Sugar().Info("Upsert metadata diff for instance ", instanceID, ": this is the first metadata for this instance") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before performing an upsert, log the differences between the existing metadata and the new metadata. This will help us understand what is happening when we see unexpected changes in the metadata.