Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Disable ironic-inspector by default #479

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dtantsur
Copy link
Member

Allow auto-discovery to be enabled with the built-in inspection.

Signed-off-by: Dmitry Tantsur [email protected]

Allow auto-discovery to be enabled with the built-in inspection.

Signed-off-by: Dmitry Tantsur <[email protected]>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 29, 2024
@dtantsur
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Mar 1, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

Let's see what fails this time.

@iurygregory
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@metal3-io-bot metal3-io-bot merged commit 6664e02 into metal3-io:main Mar 4, 2024
8 checks passed
@dtantsur dtantsur deleted the no-inspector branch March 4, 2024 16:03
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Apr 29, 2024
OCPBUGS-32351: [4.15] Update to include fixes for ironic servicing feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants