Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 bump shellcheck to v0.10.0 #485

Merged
merged 1 commit into from
Mar 8, 2024
Merged

🌱 bump shellcheck to v0.10.0 #485

merged 1 commit into from
Mar 8, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Mar 8, 2024

Shellcheck had its first release since 2022, so bump it.

/hold
project-infra needs change as well.

@tuminoid
bump shellcheck to v0.10.0
8d50630 
Shellcheck had its first release since 2022, so bump it.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/unhold
Project-infra has gone in.
/test shellcheck

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/unhold
Project-infra has gone in.
/test shellcheck

/override test-centos-integration-main test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to this:

/unhold
Project-infra has gone in.
/test shellcheck

/override test-centos-integration-main test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lentzi90
lentzi90 reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@metal3-io-bot metal3-io-bot merged commit a4a060d into metal3-io:release-24.0 Mar 8, 2024
7 of 8 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-shellcheck-24.0 branch March 8, 2024 13:40
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Jun 14, 2024
@openshift-merge-bot
Merge pull request metal3-io#485 from elfosardo/remove-prometheus-exp…
e2415c8 
…orter-415

OCPBUGS-32365: [4.15] Remove unused prometheus exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @elfosardo @lentzi90