Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove support for API/conductor split #487

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

dtantsur
Copy link
Member

Running API and conductor separately mostly makes sense in the context of large OpenStack clouds. We used to use it before the all-in-one executable appeared, but now it's untested and potentially broken.

While here, enforce authentication for JSON RPC and clean up related options.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2024
Signed-off-by: Dmitry Tantsur <[email protected]>
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2024
@dtantsur
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

/test-centos-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@metal3-io-bot metal3-io-bot merged commit 2bfb898 into metal3-io:main Mar 21, 2024
8 checks passed
@dtantsur dtantsur deleted the deprecated-arch branch March 25, 2024 15:25
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request May 2, 2024
…orter-414

OCPBUGS-32364: [4.14] remove unused prometheus-exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants