-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add ARG BASE_IMAGE to sushy-tools Dockerfile #491
🌱 add ARG BASE_IMAGE to sushy-tools Dockerfile #491
Conversation
To be consistent with other Dockerfiles, and to allow easy replacement of the base image, add ARG BASE_IMAGE to sushy-tools Dockerfile. Signed-off-by: Tuomo Tanskanen <[email protected]>
/test-centos-integration-main |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test-ubuntu-integration-main Unrelated flake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/cc @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
To be consistent with other Dockerfiles, and to allow easy replacement of the base image, add ARG BASE_IMAGE to sushy-tools Dockerfile.