✨ Provide scripts to be used as liveness/readiness probes #492
Conversation
metal3-io-bot
added
the
size/S
|
/cc @tuminoid I need to find a way to test these, they're not currently wired in. |
metal3-io-bot
added
the
do-not-merge/hold
There was a problem hiding this comment.
Slight typo.
This can be tested with dev-env PR and configuring BMO and ironic-image to point to your forks with needed changes with BMOREPO, BMOBRANCH and IRONIC_IMAGE_REPO , IRONIC_IMAGE_BRANCH (see vars.sh).
Or locally, by pointing dev-env to local repos via BMOPATH and IRONIC_IMAGE_PATH and setting BUILD_BMO_LOCALLY=true and BUILD_IRONIC_IMAGE_LOCALLY=true. Also set FORCE_REPO_UPDATE=false.
I'm running this test now locally. |
This change is the first step towards metal3-io/baremetal-operator#1528. Through these scripts, we can decouple the validation logic from the pod definition and provide more sophisticated tests in the future. Right now, the same curl command is used (modulo supporting all variants of deploying Ironic). Signed-off-by: Dmitry Tantsur <[email protected]>
metal3-io-bot
added
size/M
|
/test-centos-integration-main |
|
/test-ubuntu-integration-main |
1 similar comment
|
/test-ubuntu-integration-main |
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/cherry-pick release-24.1 |
|
@tuminoid: new pull request created: #493 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
METAL-1004: Update ironic-lib to latest release-4.14 commit
This change is the first step towards metal3-io/baremetal-operator#1528.
Through these scripts, we can decouple the validation logic from
the pod definition and provide more sophisticated tests in the future.
Right now, the same curl command is used (modulo supporting all variants
of deploying Ironic).
Signed-off-by: Dmitry Tantsur [email protected]