🐛 improve upper constraints handling #589
Conversation
metal3-io-bot
added
the
size/XS
Rozzii
changed the title
|
/cc @elfosardo |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
For reference: this is manual cherry-pick of #584 |
|
/retitle 🐛 improve upper constraints handling |
metal3-io-bot
changed the title
|
/retitle 🐛 improve upper constraints handling |
|
/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6 |
|
/retest |
1 similar comment
|
/retest |
|
/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6 |
|
I think the deps have rot already for this version: [2024-11-08T09:06:46.846Z] INFO: pip is looking at multiple versions of <Python from Requires-Python> to determine which version is compatible with other requirements. This could take a while.
[2024-11-08T09:06:46.846Z] INFO: pip is looking at multiple versions of gunicorn to determine which version is compatible with other requirements. This could take a while.
[2024-11-08T09:06:46.846Z] INFO: pip is looking at multiple versions of crudini to determine which version is compatible with other requirements. This could take a while.
[2024-11-08T09:06:46.846Z] Collecting crudini
[2024-11-08T09:06:46.846Z] Downloading crudini-0.9.4-py2.py3-none-any.whl (21 kB)
[2024-11-08T09:06:46.846Z] ERROR: Cannot install -r /tmp/ironic-source-list-final (line 5) and sushy because these package versions have conflicting dependencies.
[2024-11-08T09:06:46.846Z]
[2024-11-08T09:06:46.846Z] The conflict is caused by:
[2024-11-08T09:06:46.846Z] The user requested sushy
[2024-11-08T09:06:46.846Z] ironic 24.0.1.dev10 depends on sushy>=4.7.0
[2024-11-08T09:06:46.846Z] The user requested (constraint) sushy===4.5.2
[2024-11-08T09:06:46.846Z]
[2024-11-08T09:06:46.846Z] To fix this you could try to:
[2024-11-08T09:06:46.846Z] 1. loosen the range of package versions you've specified
[2024-11-08T09:06:46.846Z] 2. remove package versions to allow pip attempt to solve the dependency conflict
[2024-11-08T09:06:46.846Z]
[2024-11-08T09:06:46.846Z] ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
[2024-11-08T09:06:49.219Z] Error: building at STEP "RUN prepare-image.sh && rm -f /bin/prepare-image.sh": while running runtime: exit status 1 |
|
@elfosardo is it okay if I uplift the constraint ? |
Can we do quick check if its already been uplifted in the upstream? It might've changed since the contsraints file was saved here. |
|
@tuminoid at least AFAIK in the upstream branch the requirement is clear https://opendev.org/openstack/ironic/src/branch/bugfix/24.0/requirements.txt#L49 so there is not much question about it IMO. It is not possible to build it under 4.7. |
This commit: - Provides a default value for the UPPER_CONSTRAINT docker file argument - Changes the prepare-image.sh logic to check the actual size of the upper constraint file and not the presence of it. Background of this change is that it has been noticed that on release branches during image building the "pinned" upper constraint file is not picked up rather pulled from upstream OpenStack because of a lack of default argument value during image building. Signed-off-by: Adam Rozman <[email protected]>
Rozzii
force-pushed
the
cp-fix-constraint-24.0
branch
from
cfe86ab
to
278638a
Compare
|
/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6 |
Now I have checked the original release tag too and even at that time it was 4.7 https://opendev.org/openstack/ironic/src/tag/24.0.0/requirements.txt so I think setting it lower was a mistake initially too just the bug served as a "workaround". |
|
@Rozzii: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Rozzii: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Seems it will be multiple of the dependencies, I will push the fixes. |
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
This commit:
Background of this change is that it has been noticed that on release branches during image building the "pinned" upper constraint file is not picked up rather pulled from upstream OpenStack because of a lack of default argument value during image building.