Revision of structure theorems (5) - comments on extensible structures #4435
+117
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* header comment for section "7.1.1 Basic definitions" revised (header comment for section "7.1.1.4 Structure component indices" referenced instead of comment for ~ basendx) * header comment for section "7.1.1.3 Slots" revised * header comment for section "7.1.1.4 Structure component indices" added * comment for ~ basendx revised. * proofs of theorems cnfldfun and cnfldfunALT switched
icecream17
approved these changes
Nov 24, 2024
as suggested by @icecream17
|
First of all I want to thank @icecream17 for his review and hints. Then I want to ask other contributors, at least those who participated in the discussion in #3235 (@tirix @david-a-wheeler @digama0 @jkingdon @benjub @langgerard ), to have a look at the modified/enhanced comments proposed in this PR. I think extensible structures are exssential for Metamath, so they should be documented particulary well. |
|
Your revision allows for a far better understanding of the mechanism of extensible structures.
Maybe in the line 200627 you could add the word « numeric » inside « proofs instead of its numeric value 1), …"
… Le 27 nov. 2024 à 15:09, avekens ***@***.***> a écrit :
First of all I want to thank @icecream17 <https://github.com/icecream17> for his review and hints.
Then I want to ask other contributors, at least those who participated in the discussion in #3235 <#3235> ***@***.*** <https://github.com/tirix> @david-a-wheeler <https://github.com/david-a-wheeler> @digama0 <https://github.com/digama0> @jkingdon <https://github.com/jkingdon> @benjub <https://github.com/benjub> @langgerard <https://github.com/langgerard> ), to have a look at the modified/enhanced comments proposed in this PR. I think extensible structures are exssential for Metamath, so they should be documented particulary well.
—
Reply to this email directly, view it on GitHub <#4435 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANSR5QQFOAHIGILWW34QGRD2CXHB5AVCNFSM6AAAAABSMQDYT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTHE3TKMRVGE>.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #3235, the comments on extensible structures are revised to reflect the current status of the discussion.
In detail: