Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpd_allow and include directive configuration #28

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

riekelt
Copy link

@riekelt riekelt commented Oct 24, 2016

This PR allows for a configurable httpd_allow parameter (default was allow all) and additional include directives.

Riekelt Kapitein and others added 2 commits October 24, 2016 08:36
@riekelt riekelt changed the title Develop Add httpd_allow and include directive configuration Oct 24, 2016
@gytisgreitai
Copy link

@floSoX can we get this merged? Thank you

@FlorentPoinsaut FlorentPoinsaut added this to the v1.2.0 milestone Mar 15, 2017
Copy link
Collaborator

@FlorentPoinsaut FlorentPoinsaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for this PR.
I propose some changes.
Could you please update it?
Adding doc (README) and tests would be great :-)

Thank you.
Regards,

@@ -7,6 +7,7 @@
$httpd_address = $monit::params::httpd_address,
$httpd_user = $monit::params::httpd_user,
$httpd_password = $monit::params::httpd_password,
$httpd_allow = $monit::params::httpd_allow,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name the variable httpd_networks please?

@FlorentPoinsaut
Copy link
Collaborator

FlorentPoinsaut commented Oct 8, 2018

Hi,
I merged your work on a new repository: https://github.com/solution-libre/puppet-monit
You can find the new module here: https://forge.puppet.com/soli/monit
Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants