Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL and PEM support #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
## 2016-11-07 - Release 1.1.2
## 2018-09-11 - Release 1.1.2
### Summary
Based on release 1.1.2 (2016-11-07) of the original module.
This release adds support to Ubuntu Xenial and improves compatibility with Puppet Server.

#### Features
- Adds support for PEM and SSL certificate configuration
- Added support to Ubuntu 16.04.

### Bugfixes
Expand Down
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,15 @@ Specifies the user to access the Monit Dashboard. Valid options: string. Default

Specifies the password to access the Monit Dashboard. Valid options: string. Default value: 'monit'

##### `httpd_ssl'

Specifies SSL encryption for access the Monit Dashboard. Valid options: 'true' or 'false'. Default value: 'false'

##### `httpd_pemfile'

Specifies the use of the local PEM module for authentication of access the Monit Dashboard. Valid options: string
Default value: undef.

##### `logfile`

Specifies the logfile directive value. Valid options: string. Default value: '/var/log/monit.log'
Expand Down
13 changes: 13 additions & 0 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
$httpd_address = $monit::params::httpd_address,
$httpd_user = $monit::params::httpd_user,
$httpd_password = $monit::params::httpd_password,
$httpd_ssl = $monit::params::httpd_ssl,
$httpd_pemfile = $monit::params::httpd_pemfile,
$manage_firewall = $monit::params::manage_firewall,
$package_ensure = $monit::params::package_ensure,
$package_name = $monit::params::package_name,
Expand Down Expand Up @@ -64,6 +66,12 @@
} else {
$config_dir_purge_bool = $config_dir_purge
}

if is_string($httpd_ssl) == true {
$httpd_ssl_bool = str2bool($httpd_ssl)
} else {
$httpd_ssl_bool = $httpd_ssl
}
# </stringified variable handling>

# <variable validations>
Expand All @@ -73,6 +81,7 @@
validate_string($httpd_address)
validate_string($httpd_user)
validate_string($httpd_password)
validate_bool($httpd_ssl_bool)
validate_bool($manage_firewall_bool)
validate_string($package_ensure)
validate_string($package_name)
Expand Down Expand Up @@ -100,6 +109,10 @@
validate_string($mmonit_address)
}

if $httpd_pemfile != undef {
validate_absolute_path($httpd_pemfile)
}

validate_string($mmonit_port)
validate_string($mmonit_user)
validate_string($mmonit_password)
Expand Down
2 changes: 2 additions & 0 deletions manifests/params.pp
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
$httpd_address = 'localhost'
$httpd_user = 'admin'
$httpd_password = 'monit'
$httpd_ssl = false
$httpd_pemfile = undef
$manage_firewall = false
$package_ensure = 'present'
$package_name = 'monit'
Expand Down
23 changes: 23 additions & 0 deletions spec/classes/init_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,29 @@
it { should contain_file('monit_config').with_content(/#{content}/) }
end

context 'when httpd ssl with pem is enabled' do
let(:params) do
{
:httpd => true,
:httpd_ssl => true,
:httpd_pemfile => 'somePEMfile',
:httpd_port => 2420,
:httpd_address => 'otherhost',
:httpd_user => 'tester',
:httpd_password => '',
}
end
content = <<-END.gsub(/^\s+\|/, '')
|set httpd port 2420 and
| use address otherhost
| allow 0.0.0.0/0.0.0.0
| ssl enable
| pemfile somePEMfile
| allow tester read-only
END
it { should contain_file('monit_config').with_content(/#{content}/) }
end

context 'when manage_firewall and http are set to valid bool <true>' do
# kernel fact is needed for ::firewall
let(:pre_condition) { ['include ::firewall'] }
Expand Down
7 changes: 7 additions & 0 deletions templates/monitrc.erb
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ set eventqueue
set httpd port <%= @httpd_port %> and
use address <%= @httpd_address %>
allow 0.0.0.0/0.0.0.0
<%- if @httpd_ssl_bool and @httpd_pemfile -%>
ssl enable
pemfile <%= @httpd_pemfile %>
<%- if !@httpd_user.empty? && @httpd_password.empty? -%>
allow <%= @httpd_user %> read-only
<%- end -%>
<%- end -%>
<%- if !@httpd_user.empty? && !@httpd_password.empty? -%>
allow <%= @httpd_user %>:<%= @httpd_password %>
<%- end -%>
Expand Down