fix: remove opt in logic

metrotranscom · Nov 19, 2024 · 9d71f03 · 9d71f03
1 parent 7284e97
commit 9d71f03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/api/src/utilities/lottery-date-validator.ts b/api/src/utilities/lottery-date-validator.ts
@@ -15,11 +15,10 @@ export class LotteryDateParamValidator implements ValidatorConstraintInterface {
     listingEvents: ListingEvent[] | undefined,
     args: ValidationArguments,
   ) {
-    const { reviewOrderType, lotteryOptIn } = args.object as {
+    const { reviewOrderType } = args.object as {
       reviewOrderType: string;
-      lotteryOptIn: boolean;
     };
-    if (reviewOrderType === ReviewOrderTypeEnum.lottery && lotteryOptIn) {
+    if (reviewOrderType === ReviewOrderTypeEnum.lottery) {
       return !!listingEvents.find(
         (event: ListingEvent) =>
           event.type === ListingEventsTypeEnum.publicLottery &&

diff --git a/api/test/unit/utilities/lottery-date-validator.spec.ts b/api/test/unit/utilities/lottery-date-validator.spec.ts
@@ -18,7 +18,7 @@ describe('Testing OrderQueryParamValidator', () => {
     ).toBeTruthy();
   });
 
-  it('should return true if reviewOrderType is lottery and lotteryOptIn is no', () => {
+  it('should return false if reviewOrderType is lottery and lotteryOptIn is no', () => {
     const lotteryDateParamValidator = new LotteryDateParamValidator();
     expect(
       lotteryDateParamValidator.validate([], {
@@ -31,7 +31,7 @@ describe('Testing OrderQueryParamValidator', () => {
         constraints: [],
         targetName: '',
       }),
-    ).toBeTruthy();
+    ).toBeFalsy();
   });
 
   it('should return false if reviewOrderType is lottery and lotteryOptIn is yes and listingEvents is empty', () => {