Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ami chart selection bug #1010

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: ami chart selection bug #1010

merged 2 commits into from
Dec 23, 2024

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Dec 16, 2024

This PR addresses #984

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

There is an intermittent issue where when you go to a listing edit page and open a unit drawer, if the unit has an ami chart selected that is not first in the list - sometimes the unit drawer will load with the first ami chart selected anyway.

How Can This Be Tested/Reviewed?

The new seed has multiple ami charts. Create a listing with a unit that has an ami chart selected that is not the first chart that appears in the dropdown. Re-open the edit page and open the unit drawer and ensure the proper ami chart is selected.

Will backport the fix to core.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski marked this pull request as ready for review December 18, 2024 03:20
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one cleanup comment, otherwise looks good!

api/prisma/seed-staging.ts Outdated Show resolved Hide resolved
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Dec 19, 2024
@emilyjablonski emilyjablonski merged commit 7fcf933 into main Dec 23, 2024
16 checks passed
@emilyjablonski emilyjablonski deleted the 984/ami-selection branch December 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants