fix: make drawer accessible in mobile landscape #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documenting offline discussion. Given this is my current experience on mobile landscape with the fix, this is on hold to update the filter and total results to show on the same line and hopefully provide more room to use the drawer 🐧 |
ColinBuyck
approved these changes
Dec 18, 2024
ColinBuyck
added
ready to merge
Doorway Cypress Public
|
||||||||||||||||||||||||||||
| Project |
Doorway Cypress Public
|
| Branch Review |
landscape-map
|
| Run status |
|
| Run duration | 01m 22s |
| Commit |
|
| Committer | Emily Jablonski |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1012
Description
Out of bash, we need on mobile devices in landscape mode looking at the map to be able to access the listings list. On production right now, you can see a little sliver, and on staging, you can't see it at all. This PR makes it so the list is accessible, but doesn't improve upon the experience.
This PR:
How Can This Be Tested/Reviewed?
Using your mobile device, visit the listings map on landscape, and ensure the list is accessible. You can compare the experience to production. There are instructions here for visiting your local stack in a mobile device. You can also toggle landscape mode on and off in the browser's mobile emulator.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: