-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: partners seeing all listings in list #1015
Conversation
api/test/integration/permission-tests/permission-as-partner-correct-listing.e2e-spec.ts
Show resolved
Hide resolved
question: I wasn't able to review the other map PRs, was it discussed that we were switching GET endpoints to POST? This pattern diverges from RESTful practices and the rest of our system so am wondering what the reasoning behind it was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice quick fix! I do notice that if you go to a listing you don't have permission to see in staging it sends you to a fully white page rather than an error page. That is a bug in main as well though so we don't need to tackle it as part of this.
@mcgarrye https://github.com/metrotranscom/doorway/pull/899/files#r1839233455 Indeed! This was actually Yazeed's work, filtering listings by IDs was too large to send as a query |
This PR addresses #1014
Description
The partners list was no longer filtering by jurisdiction. The cause was that for the map, we changed the structure of the combined list to send filter parameters in the body, which updated some of the swagger for the filters, but we didn't update the generic list to send parameters in the body as well.
How Can This Be Tested/Reviewed?
Create a partner and assign them only to some jurisdictions / listings. Ensure they only see those listings in the list.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: