Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partners seeing all listings in list #1015

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

emilyjablonski
Copy link
Collaborator

This PR addresses #1014

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The partners list was no longer filtering by jurisdiction. The cause was that for the map, we changed the structure of the combined list to send filter parameters in the body, which updated some of the swagger for the filters, but we didn't update the generic list to send parameters in the body as well.

How Can This Be Tested/Reviewed?

Create a partner and assign them only to some jurisdictions / listings. Ensure they only see those listings in the list.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski marked this pull request as ready for review December 18, 2024 03:14
@mcgarrye
Copy link
Collaborator

question: I wasn't able to review the other map PRs, was it discussed that we were switching GET endpoints to POST? This pattern diverges from RESTful practices and the rest of our system so am wondering what the reasoning behind it was

Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Dec 18, 2024
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix! I do notice that if you go to a listing you don't have permission to see in staging it sends you to a fully white page rather than an error page. That is a bug in main as well though so we don't need to tackle it as part of this.

api/src/controllers/listing.controller.ts Show resolved Hide resolved
@emilyjablonski
Copy link
Collaborator Author

@mcgarrye https://github.com/metrotranscom/doorway/pull/899/files#r1839233455 Indeed! This was actually Yazeed's work, filtering listings by IDs was too large to send as a query

@emilyjablonski emilyjablonski merged commit d1c4c10 into main Dec 18, 2024
16 checks passed
@emilyjablonski emilyjablonski deleted the 1014/partners-seeing-listings-in-list branch December 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants