Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn off autofill #1017

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: turn off autofill #1017

merged 1 commit into from
Dec 18, 2024

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Dec 18, 2024

Description

This PR temporarily turns autofill off based on this Slack support issue.

How Can This Be Tested/Reviewed?

Ensure you don't hit the autofill page after already submitting an application.

Author Checklist:

Partially addresses #1016

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski marked this pull request as ready for review December 18, 2024 04:51
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as intended. We are not in a place yet to implement it, but I think autofill would be a good candidate for a feature flag. For now this is our best option

@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Dec 18, 2024
@emilyjablonski emilyjablonski merged commit 60d30ae into main Dec 18, 2024
16 checks passed
@emilyjablonski emilyjablonski deleted the autofill-off branch December 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants