Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct ami percentage in csv #1026

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: use correct ami percentage in csv #1026

merged 1 commit into from
Jan 2, 2025

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Dec 22, 2024

This PR addresses #1027

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The listing units csv export is displaying the incorrect AMI Chart percentage. It is grabbing the first value from the amiChart instead of getting the percentage off of the unit table

Note:

  • There are currently no tests that cover this part of the code and we should add those as a separate issue
  • A separate PR will be created in core and HBA

How Can This Be Tested/Reviewed?

After a clean reseed In the partner site click the "Export to CSV" button on the listings page and compare the values to the listings

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ludtkemorgan ludtkemorgan marked this pull request as ready for review December 23, 2024 20:18
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧇

@ColinBuyck ColinBuyck added the ready to merge Should be applied when a PR has been reviewed and approved label Dec 23, 2024
@ludtkemorgan ludtkemorgan merged commit ff90bb3 into main Jan 2, 2025
16 checks passed
@ludtkemorgan ludtkemorgan deleted the amiChartCsv branch January 2, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants