Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link updates #390

Merged
merged 4 commits into from
Oct 27, 2023
Merged

fix: link updates #390

merged 4 commits into from
Oct 27, 2023

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Oct 16, 2023

Pull Request Template

Issue Overview

This PR addresses #389

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

After discussions with both product and design, it seems that a broader alignment of Doorway links is needed but not within the scope of this ticket. As a result, this ticket only does the following

  1. Underline the "Dahlia" link on the home page search and the listings page filter modal
  2. Underline the Bay Area Housing Finance Authority (BAHFA) link on the homepage
  3. Underline and update the color of all links within the partners and help center pages through the Doorway Linkable Card group.

This partial color change is to address the issue with not finding links within those help pages while giving us time to resolve the contrast issues that come up if doing this globally. That follow up is captured here.

How Can This Be Tested/Reviewed?

Ensure that the three points above are covered by running this locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ColinBuyck ColinBuyck changed the title fix: wip global change fix: link updates Oct 25, 2023
@ColinBuyck ColinBuyck marked this pull request as ready for review October 25, 2023 22:20
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Oct 27, 2023
@ColinBuyck ColinBuyck merged commit df41ced into main Oct 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants