fix: type fix for s3-file-service #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinBuyck
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of @AWS-SDK makes a typing change that breaks a place in our code. Specifically this commit: aws/aws-sdk-js-v3@7d31222 changes the type from
StorageClass?: StorageClass | string;toStorageClass?: StorageClass;Due to the way Doorway is getting built for Docker it doesn't always grab the same version of dependencies that we expect. I plan on solving some of these issues with the improvements to the Doorway pipeline. But in the meantime here is a fix for this immediate issue to allow us the ability to release.