fix: add safety checks on migration script #431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging the jurisdictional refactor PR the following error happened when running the migration in the staging environment
This is most likely because there are listings in the staging environment that don't have a county associated to them. This change does a check to make sure the matching jurisdiction exists before doing anything to the listing.
this means that there might be some properties still tied to the bayArea jurisdiction, but we can manually update those if necessary
How Can This Be Tested/Reviewed?
The script should still run as before and you can use the instructions here to test: #377
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.