Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2024 02 12 v2 #476

Merged
merged 20 commits into from
Feb 21, 2024
Merged

Release/2024 02 12 v2 #476

merged 20 commits into from
Feb 21, 2024

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Feb 12, 2024 •
edited by ColinBuyck
Loading

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Please include a summary of the change and which issue(s) is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ColinBuyck ColinBuyck force-pushed the release/2024-02-12-v2 branch from cb2b76c to b222888 Compare February 15, 2024 01:06
cade-exygy and others added 18 commits February 15, 2024 16:13
@cade-exygy @ColinBuyck
feat: 3761/direct to sign in (bloom-housing#3816)
4a07ae2 
* feat: check if user is logged in

* fix: clean up logs

* fix: remove unneeded prop

* fix: sign in before submit application test

* fix: add feature toggle

* fix: sign in before submitApplication tests

* fix: fix test

* fix: add feature flag to circleCI

* fix: remove toggle

* refactor: move redirect logic to ListingView
@ColinBuyck
feat: 422/updated account theming (bloom-housing#3791)
e509985 
* fix: rough draft refactoring

* fix: wip seeds card

* fix: wip account updates

* fix: account card styling

* fix: wip status item styling

* fix: edit screen adjustments

* fix: css matched app view

* fix: testing fixes

* fix: getById chnage

* fix: add plural copy fix

* fix: json update

* fix: remove tailwind

* fix: font weight touches

* fix: mantain translations

* fix: reorganizing files

* fix: svg updates

* fix: current pswd translations

* fix: unused css

* fix: width needed

* fix: css and heading updates

* fix: account card updates

* fix: partial new icon approach

* fix: final tweaks

* fix: no border figma matching
@ColinBuyck
fix: add divider width (bloom-housing#3841)
ad9422a 
* fix: add divider width

* fix: remove space
@cade-exygy @ColinBuyck
feat: 3753/ma sign in copy (bloom-housing#3811)
3c66653 
* feat: add sign-in copy for mandated accounts

* refactor: signUpBenefits component

* feat(component): allow classNames to be applied and overridden

* feat: allow Sign Copy to be mobile responsive

* feat: show and hide correct layout based on screen size

* refactor: signUpBenefits component

* fix: 3753 fix typescript errors

* fix: fix null errors

* fix: remove type cast

* fix: fix import

* fix: 3753 remove duplicate sign in form

* fix: add feature toggle

* fix: clean up sign-in page

* fix: address issue with email input losing focus

* fix: add feature toggle

* fix: remvoe MA flag from circleCI

* fix: sort strings

* refactor: signUpBenefitsHeadingGroup component

* fix: style fixes

* fix: adjust padding

* refactor: clean up classNames
@cade-exygy @ColinBuyck
feat: 3760/redirect to application (bloom-housing#3839)
956d05c 
* feat: redirect user after forget password email

* refactor: parse query params as strings

* feat: redirect user to application after create account

* feat: confirmation Modal redirect

* feat: redirect after resendConfirmation button

* fix: add SHOW_MANDATED_ACCOUNTS var

* refactor: check feature toggle first

* fix: maintain default behavior when SHOW_MANDATED_ACCOUNTS is FALSE

* refactor: remove bend feature toggle

* refactor: add helper

* refactor: helper function to generate email url

* refactor: getListingRedirectUrl helper

* style: cleanup

* fix: cleanup
@cliu02 @cade-exygy @ColinBuyck
feat: add MA account creation styling (bloom-housing#3817)
80d728c 
* feat: update copy strings

* feat: update error strings

* feat: add show password

* feat: add form styling

* feat: update form styling

* fix: revert to previous password

* fix: update strings

* fix: remove tailwind apply

* fix: use seeds Card

* fix: update heading size

* fix: use style variables

* fix: alphabetize strings

* fix: use CardSection

* fix: use AccountCard

* fix: remove strings

* fix: update strings

* fix: remove doorway env

* fix: remove CardSection classNames

* fix: remove input colors

* fix: your name style

* feat: make emailConfirmation optional on the user-create dto

* fix: emailConfirmation optional

* fix: add AccountCard styles

* fix: change h2

* fix: override CardSection style with divider

* fix: update divider

* fix: style tweaks

---------

Co-authored-by: Cade Wolcott <[email protected]>
@cade-exygy @ColinBuyck @cliu02
feat: create Sign Up Copy (bloom-housing#3880)
3820ddd 
* feat: create Sign Up Copy

* fix: style fix

* fix: reinstate success dto

* fix: update icon margin

---------

Co-authored-by: ColinBuyck <[email protected]>
Co-authored-by: cliu02 <[email protected]>
@cliu02 @ColinBuyck
feat: add MA sign in styling (bloom-housing#3820)
dd918c3
@cliu02 @ColinBuyck
feat: add MA application check for signed-in user (bloom-housing#3850)
d734a39
@cade-exygy @ColinBuyck
feat: ma-3752 add flag (bloom-housing#3773)
dc6fb30 
* feat: mA-3752 feat: add SHOW_MANDATED_ACCOUNTS flag

* fix: add feature flag to bloom public next config

* fix: remove flag from partners
@ColinBuyck
fix: shared-helpers tailwind config (#479)
2b8ecdc
@ColinBuyck
feat: account design updates (bloom-housing#3853)
31b2780 
* fix: updates per Jesse feedback

* fix: generalize application view

* fix: heading level and typography updates

* fix: confirmation page changes

* fix: applications spacing changes

* fix: no results updates

* fix: update prisma typing

* fix: back href

* fix: final tweaks

* fix: aligning mobile view and css class names

* fix: remove testing line
@emilyjablonski @cade-exygy
@cliu02 @ColinBuyck
feat: mandated accounts followup (#477)
8a3a1d8 
Co-authored-by: Cade Wolcott <[email protected]>
Co-authored-by: cliu02 <[email protected]>
Co-authored-by: ColinBuyck <[email protected]>
@KrissDrawing @ColinBuyck
fix: align multiselect questions with design (bloom-housing#3842)
cc8f74b
@ColinBuyck
fix: mandated accounts check for sign in (#482)
73a3f3f
@emilyjablonski @ColinBuyck
fix: add args to build files
b29342a
@emilyjablonski @ColinBuyck
fix: alert box background color fix
ac49490
@cade-exygy @ColinBuyck
fix: no longer pull redirectUrl from router query
9dfad3f
@ColinBuyck ColinBuyck force-pushed the release/2024-02-12-v2 branch from 3884340 to 9dfad3f Compare February 16, 2024 00:14
@cade-exygy
Copy link
Collaborator

@ColinBuyck @emilyjablonski Are there any pieces of follow-up work here I can help with?

@ludtkemorgan
Copy link
Collaborator

@ColinBuyck is this ready to be reviewed?

@ColinBuyck
Copy link
Collaborator

ColinBuyck commented Feb 20, 2024 •
edited
Loading

Yep ⛱️ @ludtkemorgan! And with those testing fixes I just pushed, I think just helping with any PR feedback would be great @cade-exygy

YazeedLoonat
YazeedLoonat approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Feb 20, 2024
@ColinBuyck ColinBuyck merged commit 38802ef into main Feb 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cade-exygy cade-exygy cade-exygy left review comments

@ColinBuyck ColinBuyck ColinBuyck left review comments

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

@YazeedLoonat YazeedLoonat YazeedLoonat approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@emilyjablonski @cade-exygy @ludtkemorgan @ColinBuyck @YazeedLoonat @cliu02 @KrissDrawing