Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minimal change approach #484

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: minimal change approach #484

merged 3 commits into from
Feb 15, 2024

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Feb 15, 2024

Pull Request Template

Issue Overview

This PR addresses #457

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR updates the demographic header + subheader text along with hiding the howDidYouHear section per QA notes. There are still outstanding questipns around the selection type for the other demographic questions.

NOTE: Since howDidYouHear data is tied to the verify endpoint along with many types and tests. This PR is meat to be a quick fix until a more formal decision to remove howDidYouHear across the application and until Prisma is merged in.

How Can This Be Tested/Reviewed?

Ensure the demographics page matches the Revised Demographic Section of this document

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ColinBuyck ColinBuyck marked this pull request as ready for review February 15, 2024 05:15
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to have this be a followup, but atm if I fill out the demographics page, continue to review, and then navigate back, my answers don't pre-populate like they do on other pages.

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Feb 15, 2024
@ColinBuyck
Copy link
Collaborator Author

Fixed that default value issue and just going to wait for tests to pass before merging 🎃 @emilyjablonski

@ColinBuyck ColinBuyck merged commit c9ec43b into main Feb 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants