fix: map images correctly for external #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #issue
Description
With the latest mapping of the prisma object for the combined listing the images on the listings page don't work for external listings. This is due to the change from "images" to "assets". The latest change accounted for this, but did not consider that the images are in an array. so the "images" need to be set on each image rather than at the top level
How Can This Be Tested/Reviewed?
BLOOM_API_BASE=https://hba-0-3-alameda-staging.herokuapp.com
yarn db:reseed:with-external:dev
. This will pull in the listings from hba staging environmentChecklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.