Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates to the pipeline #515

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: updates to the pipeline #515

merged 1 commit into from
Mar 12, 2024

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Mar 12, 2024

The AWS pipeline is failing for the following reasons:

  • backend build fails because the unit tests are run before fully building. They are failing because there are missing environment variables. However, since nothing can get into the main branch without tests passing on the PR, I think it makes sense to disable the tests to make the build even faster.
  • The dev migration script takes down the db and rebuilds it from scratch. Because of that we can't skip the migrations we will need to do in prod. I have updated the docker file to accommodate both use cases and have the dev migration not skip any of the migrations

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YazeedLoonat YazeedLoonat added the ready to merge Should be applied when a PR has been reviewed and approved label Mar 12, 2024
@ludtkemorgan ludtkemorgan merged commit db7bba9 into main Mar 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants