-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove ability to edit close and lottery dates on a published listing #623
fix: remove ability to edit close and lottery dates on a published listing #623
Conversation
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KrissDrawing, just a bit of code structure feedback. TY!
sites/partners/src/components/listings/PaperListingForm/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jurisdictional Admins and Partners can still switch listing availability
between Available Units
and Open Waitlist
which can cause problems with existing FCFS or Lottery setup.
Additionally, when I try to make any change not as an admin to a lottery listing I cannot save my changes because the disabled fields are sending back empty data. Fields should contain the current data so they send back correctly.
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing # Conflicts: # sites/partners/src/components/listings/PaperListingForm/index.tsx
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing # Conflicts: # api/test/unit/services/listing.service.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api/test/integration/permission-tests/permission-as-juris-admin-correct-juris.e2e-spec.ts
Outdated
Show resolved
Hide resolved
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing
Change looks great! |
…ve-ability-to-edit-close-and-lottery-dates-on-a-published-listing
Pull Request Template
Issue Overview
This PR addresses #570
Description
Disables ability to edit due dates for active listings by non admin users. Also blocks switching between FCFS and Lottery
How Can This Be Tested/Reviewed?
disableDueDates
anddisableDueDate
tofalse
).Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.