Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match import with app file #644

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: match import with app file #644

merged 2 commits into from
May 28, 2024

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented May 23, 2024

Pull Request Template

Issue Overview

This PR addresses #560

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR updates the router we use from the NavigationContext of UI-C to Doorway-UI-C router which is used as a provider in the _app.tsx file. Ideally, we'd be off the Doorway-UI-C version all together but since this is such a specific fix, I decided it would be out of scope to do this alignment. Instead, it is captured here #645

How Can This Be Tested/Reviewed?

This takes a bit to test but it's worth it 🥳

  1. Update the IDLE_TIMEOUT env variable to 1
  2. Run PR locally
  3. Sign in to a public account
  4. Leave that window alone and do something else!
  5. When you remember come back and see that you've been redirected to the sign in page

You can reproduce the steps above on main to see that you'll end up on a blank screen.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ColinBuyck ColinBuyck marked this pull request as ready for review May 23, 2024 21:42
Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels May 28, 2024
@ColinBuyck ColinBuyck force-pushed the 560/timeout-redirect-2 branch from 19cba4c to b285685 Compare May 28, 2024 16:44
@ColinBuyck ColinBuyck force-pushed the 560/timeout-redirect-2 branch from b285685 to e5aba11 Compare May 28, 2024 20:22
@ColinBuyck ColinBuyck merged commit a0633c9 into main May 28, 2024
16 checks passed
@ColinBuyck ColinBuyck deleted the 560/timeout-redirect-2 branch May 28, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants