Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce max length #969

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: enforce max length #969

merged 1 commit into from
Dec 2, 2024

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Nov 27, 2024

This PR addresses #941

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR updates the preference drawer to include FE validation that the title is no more than 32 characters.

Note that I intentionally did not include this validation on the BE since the issue indicated enforcing this via the UI and changing the multiselect questions dto would have implications for programs as well. I imagine BE validation will be brought over once we develop a sustainable solution for Core + HBA. As a reminder, those jurisdictions currently have preferences over that character limit so this change is made in Doorway rather than Core.

How Can This Be Tested/Reviewed?

Add a new preference and try saving a new preference with no title filled out and then a title over 32 characters to observe the dynamic error message.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Dec 2, 2024
@ColinBuyck ColinBuyck merged commit 83d34cc into main Dec 2, 2024
16 checks passed
@ColinBuyck ColinBuyck deleted the 941/preference-title-length branch December 2, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants