Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for limited juris role #973

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses #943

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR updates the lottery tab logic to not show if the user is a limited juris no PII user.

How Can This Be Tested/Reviewed?

This can be tested by signing in to a limited juris user and viewing a closed lottery listing. There should be no lottery tab visible. Now check out that same listing with other roles and it should still be visible.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Dec 2, 2024
@ColinBuyck ColinBuyck merged commit 756c211 into main Dec 3, 2024
16 checks passed
@ColinBuyck ColinBuyck deleted the 943/hide-lottery-no-pii branch December 3, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants