Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: building selection criteria adjustment #991

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Dec 10, 2024

This PR addresses #(982)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Listings with a BuildingSelectionCriteriaFile could not be duplicated due to an issue re-creating the asset. This is fixed by not passing the existing asset id to the new copy.

How Can This Be Tested/Reviewed?

  • Create or edit a listing to have a building selection criteria file.
  • Copy the listing
  • Confirm the building selection criteria file is present on the copy listing
  • Publish the copy listing
  • Go to the public site, view the copy listing, view the building selection criteria file

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕹️ just one nit

api/src/services/listing.service.ts Show resolved Hide resolved
@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Dec 10, 2024
@mcgarrye mcgarrye merged commit d7e6096 into main Dec 12, 2024
16 checks passed
@mcgarrye mcgarrye deleted the release/feature-flags-and-duplication-fix branch December 12, 2024 16:27
@mcgarrye mcgarrye removed the ready to merge Should be applied when a PR has been reviewed and approved label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants