Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker uses lockfile #996

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: docker uses lockfile #996

merged 1 commit into from
Dec 11, 2024

Conversation

mcgarrye
Copy link
Collaborator

This PR addresses #(insert-number-here)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Docker build now always uses yarn.lock file for packages.

How Can This Be Tested/Reviewed?

Run docker build . -f build/docker/Dockerfile.backend --target run -t api:run-candidate locally and see that there is no info No lockfile found. in the logs.
To view logs, open link provided after build completes in the browser.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Dec 11, 2024
@mcgarrye mcgarrye merged commit 45582a3 into main Dec 11, 2024
16 checks passed
@mcgarrye mcgarrye deleted the fix/docker-use-lockfile branch December 11, 2024 16:43
@mcgarrye mcgarrye removed the ready to merge Should be applied when a PR has been reviewed and approved label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants