Transcribe #28

meyertst-aws · 2024-11-06T19:25:01Z

This pull request...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

meyertst-aws · 2024-11-06T19:33:38Z

...cribe/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+and handling the transcription response.
+ */
+
+public class TranscribeMedicalStreamingDemoApp {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This class references 43 other classes. By comparison, 98% of the classes in the CodeGuru reference dataset reference fewer. This indicates that this class is highly coupled with other classes. A class that is highly coupled with other classes is difficult to understand and its behavior might change unexpectedly when one of its referenced classes is updated. High coupling could also increase the integration test complexity, maintenance cost and technical debt. We recommend that you simplify this class or break it into multiple classes.

meyertst-aws · 2024-11-06T19:33:38Z

python/example_code/s3/scenarios/conditional_requests/scenario.py

+        """
+        try:
+            # Get list of all objects in the bucket.
+            list_response = self.s3_client.list_objects_v2(Bucket=bucket_name)


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

The API method list_objects_v2 returns paginated results instead of all results. Consider using the pagination API or checking one of the following keys in the response to verify that all results were returned: ContinuationToken, IsTruncated, NextContinuationToken, NextToken.

Learn more

meyertst-aws · 2024-11-06T19:33:39Z

python/example_code/s3/scenarios/conditional_requests/scenario.py

+            "CopySourceIfUnmodifiedSince",
+        ]
+
+        yesterday_date = datetime.datetime.utcnow() - datetime.timedelta(days=1)


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Naive datetime objects are treated by many datetime methods as local times, We recommend that you create aware timestamps with the now or fromtimestamp functions using the tzinfo to attribute to represent times in UTC. Do not use the datetime.utcnow() because it returns only a naive datetime object.

Learn more

meyertst-aws · 2024-11-06T19:33:39Z

...cribe/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+            System.exit(0);
+        }
+
+        TargetDataLine line = (TargetDataLine) AudioSystem.getLine(info);


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Problem
This line of code might contain a resource leak. Resource leaks can cause your system to slow down or crash.

Fix
Consider closing the following resource: line. Currently, there are execution paths that do not contain closure statements, for example, when TargetDataLine.open throws an exception. Ensure line is closed in a try-finally block or declared in a try-with-resources block.

More info
View resource management guidelines at oracle.com (external link).

meyertst-aws · 2024-11-06T19:33:39Z

...cribe/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+            new AudioStreamPublisher(getStreamFromMic()),
+            getMedicalResponseHandler());
+
+        result.get();


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It looks like you are using CompletableFuture.get() or Future.get() without setting its timeout parameter. Be sure to set timeout values or handle timeout exceptions to prevent threads from waiting for a process to end. This can lead to downtime for your customers. For more information, see CompletableFuture and Future documentation.

Suggested remediation:
Set timeout parameters for CompletableFuture.get() or Future.get().Exceptions, such as ExecutionException, InterruptedException and TimeoutException are caught and errors are logged.

@@ -54,3 +54,14 @@ - result.get(); + try { + result.get(100, TimeUnit.MILLISECONDS); + } catch (InterruptedException ie) { + log.error("Thread interrupted.", ie); + throw new InterruptedException(ie.getMessage()); + } catch (ExecutionException xe) { + log.error("The task aborted when attempting to retrieve its result.", xe); + throw new ExecutionException(xe.getMessage()); + } catch (TimeoutException te) { + log.error("Future is not done when timeout.", te); + throw new TimeoutException(te.getMessage()); + } client.close();

meyertst-aws · 2024-11-06T19:33:39Z

gov2/s3/actions/bucket_basics.go

+			}
+		} else if len(output.Errors) > 0 {
+			for _, outErr := range output.Errors {
+				log.Printf("%s: %s\n", *outErr.Key, *outErr.Message)


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Attempting to access memory locations that are null or uninitialized can lead to nil pointer dereferences and crashes. Always check that pointers are not nil before dereferencing them. Validate return values from functions that provide pointers, and handle potential nil values appropriately. Adding nil checks will prevent unexpected errors and issues when accessing memory.

Suggested remediation:
We recommend the following changes to mitigate the issue.

@@ -365,5 +365,10 @@ } else if len(output.Errors) > 0 { for _, outErr := range output.Errors { - log.Printf("%s: %s\n", *outErr.Key, *outErr.Message) + if outErr != nil { + log.Printf("%s: %s\n", *outErr.Key, *outErr.Message) +} +else { + log.Fatal("Error: Attempting to dereference a nil pointer") +} } err = fmt.Errorf("%s", *output.Errors[0].Message)

meyertst-aws · 2024-11-06T19:33:39Z

gov2/workflows/s3_object_lock/actions/s3_actions.go

+			err = s3.NewObjectNotExistsWaiter(actor.S3Client).Wait(
+				ctx, &s3.HeadObjectInput{Bucket: aws.String(bucket), Key: delObjs.Key}, time.Minute)
+			if err != nil {
+				log.Printf("Failed attempt to wait for object %s to be deleted.\n", *delObjs.Key)


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Attempting to access memory locations that are null or uninitialized can lead to nil pointer dereferences and crashes. Always check that pointers are not nil before dereferencing them. Validate return values from functions that provide pointers, and handle potential nil values appropriately. Adding nil checks will prevent unexpected errors and issues when accessing memory.

meyertst-aws · 2024-11-06T19:33:39Z

gov2/s3/actions/bucket_basics.go

+			for _, outErr := range output.Errors {
+				log.Printf("%s: %s\n", *outErr.Key, *outErr.Message)
+			}
+			err = fmt.Errorf("%s", *output.Errors[0].Message)


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Attempting to access memory locations that are null or uninitialized can lead to nil pointer dereferences and crashes. Always check that pointers are not nil before dereferencing them. Validate return values from functions that provide pointers, and handle potential nil values appropriately. Adding nil checks will prevent unexpected errors and issues when accessing memory.

meyertst-aws · 2024-11-06T19:33:40Z

gov2/s3/actions/bucket_basics.go

+			err = s3.NewObjectNotExistsWaiter(basics.S3Client).Wait(
+				ctx, &s3.HeadObjectInput{Bucket: aws.String(bucketName), Key: delObjs.Key}, time.Minute)
+			if err != nil {
+				log.Printf("Failed attempt to wait for object %s to be deleted.\n", *delObjs.Key)


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Attempting to access memory locations that are null or uninitialized can lead to nil pointer dereferences and crashes. Always check that pointers are not nil before dereferencing them. Validate return values from functions that provide pointers, and handle potential nil values appropriately. Adding nil checks will prevent unexpected errors and issues when accessing memory.

meyertst-aws · 2024-11-06T19:33:40Z

gov2/lambda/scenarios/scenario_get_started_functions.go

+	if err != nil {
+		log.Panicf("Couldn't create destination archive %v. Here's why: %v\n", destinationFile, err)
+	}
+	sourceBody, err := os.ReadFile(fmt.Sprintf("%v/%v", helper.HandlerPath, sourceFile))


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

User input controlling server file access enables path traversal, allowing access to unintended files. Sanitize and validate file paths before usage. Recommend allowlisting permitted paths and filenames. Never concatenate or join user input into filesystem paths. Input validation prevents malicious actors from accessing sensitive files.

meyertst-aws · 2024-11-06T20:07:15Z

...cribe/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+and handling the transcription response.
+ */
+
+public class TranscribeMedicalStreamingDemoApp {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This class references 42 other classes. By comparison, 98% of the classes in the CodeGuru reference dataset reference fewer. This indicates that this class is highly coupled with other classes. A class that is highly coupled with other classes is difficult to understand and its behavior might change unexpectedly when one of its referenced classes is updated. High coupling could also increase the integration test complexity, maintenance cost and technical debt. We recommend that you simplify this class or break it into multiple classes.

meyertst-aws · 2024-11-06T20:07:15Z

...cribe/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+            new AudioStreamPublisher(getStreamFromMic()),
+            getMedicalResponseHandler());
+
+        result.get();


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It looks like you are using CompletableFuture.get() or Future.get() without setting its timeout parameter. Be sure to set timeout values or handle timeout exceptions to prevent threads from waiting for a process to end. This can lead to downtime for your customers. For more information, see CompletableFuture and Future documentation.

Suggested remediation:
Set timeout parameters for CompletableFuture.get() or Future.get().Exceptions, such as ExecutionException, InterruptedException and TimeoutException are caught and errors are logged.

@@ -52,3 +52,14 @@ - result.get(); + try { + result.get(100, TimeUnit.MILLISECONDS); + } catch (InterruptedException ie) { + log.error("Thread interrupted.", ie); + throw new InterruptedException(ie.getMessage()); + } catch (ExecutionException xe) { + log.error("The task aborted when attempting to retrieve its result.", xe); + throw new ExecutionException(xe.getMessage()); + } catch (TimeoutException te) { + log.error("Future is not done when timeout.", te); + throw new TimeoutException(te.getMessage()); + } client.close();

meyertst-aws · 2024-11-08T20:06:52Z

...be-streaming/src/main/java/com/amazonaws/transcribestreaming/TranscribeStreamingDemoApp.java

+import java.util.concurrent.atomic.AtomicLong;
+
+// snippet-start:[transcribe.java-streaming-demo]
+public class TranscribeStreamingDemoApp {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This class references 48 other classes. By comparison, 98% of the classes in the CodeGuru reference dataset reference fewer. This indicates that this class is highly coupled with other classes. A class that is highly coupled with other classes is difficult to understand and its behavior might change unexpectedly when one of its referenced classes is updated. High coupling could also increase the integration test complexity, maintenance cost and technical debt. We recommend that you simplify this class or break it into multiple classes.

meyertst-aws · 2024-11-08T20:06:52Z

...aming/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+and handling the transcription response.
+ */
+
+public class TranscribeMedicalStreamingDemoApp {


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This class references 42 other classes. By comparison, 98% of the classes in the CodeGuru reference dataset reference fewer. This indicates that this class is highly coupled with other classes. A class that is highly coupled with other classes is difficult to understand and its behavior might change unexpectedly when one of its referenced classes is updated. High coupling could also increase the integration test complexity, maintenance cost and technical debt. We recommend that you simplify this class or break it into multiple classes.

meyertst-aws · 2024-11-08T20:06:52Z

...be-streaming/src/main/java/com/amazonaws/transcribestreaming/TranscribeStreamingDemoApp.java

+            System.out.println("Line not supported");
+            System.exit(0);
+        }
+


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Problem
This line of code might contain a resource leak. Resource leaks can cause your system to slow down or crash.

Fix
Consider closing the following resource: line. Currently, there are execution paths that do not contain closure statements, for example, when TargetDataLine.open throws an exception. Ensure line is closed in a try-finally block or declared in a try-with-resources block.

More info
View resource management guidelines at oracle.com (external link).

meyertst-aws · 2024-11-08T20:06:52Z

...scribe-streaming/src/main/java/com/amazonaws/transcribestreaming/BidirectionalStreaming.java

+        AudioFormat format = new AudioFormat(16000, 16, 1, true, false);
+        DataLine.Info datalineInfo = new DataLine.Info(TargetDataLine.class, format);
+
+        TargetDataLine dataLine = (TargetDataLine) AudioSystem.getLine(datalineInfo);


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Problem
This line of code contains a resource that might not be closed properly. This can cause a resource leak that slows down or crashes your system.

Fix
Consider closing the following resource: dataLine. The resource is referenced at lines 73, 74. The resource is returned at line 75. There are other execution paths that don't close the resource or return it, for example, when TargetDataLine.open throws an exception. To prevent this resource leak, close dataLine along these other paths before you exit this method.

More info
View resource management guidelines at oracle.com (external link).

meyertst-aws · 2024-11-08T20:06:52Z

...aming/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+            throw new LineUnavailableException("The audio system microphone line is not supported.");
+        }
+
+        TargetDataLine line = (TargetDataLine) AudioSystem.getLine(info);


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Problem
This line of code might contain a resource leak. Resource leaks can cause your system to slow down or crash.

Fix
Consider closing the following resource: line. Currently, there are execution paths that do not contain closure statements, for example, when TargetDataLine.open throws an exception. Ensure line is closed in a try-finally block or declared in a try-with-resources block.

More info
View resource management guidelines at oracle.com (external link).

meyertst-aws · 2024-11-08T20:06:53Z

.../transcribe-streaming/src/main/java/com/amazonaws/transcribestreaming/StreamingRetryApp.java

+         * Create Amazon Transcribe streaming retry client.
+         */
+
+        TranscribeStreamingRetryClient client = new TranscribeStreamingRetryClient(


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Problem
Analysis of this package determined that this line of code contains a resource that might not have closed properly. A resource leak can slow down or crash your system.

Fix
Consider closing the following resource in a try-finally block: client. The resource is referenced at line 51. The resource is closed at line 72. There are other execution paths that do not contain closure statements, for example, when FileInputStream constructor throws an exception.

More info
View resource management guidelines at oracle.com (external link).

meyertst-aws · 2024-11-08T20:06:53Z

...e-streaming/src/main/java/com/amazonaws/transcribestreaming/TranscribeStreamingDemoFile.java

+                new AudioStreamPublisher(getStreamFromFile(file)),
+                getResponseHandler());
+
+        result.get();


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It looks like you are using CompletableFuture.get() or Future.get() without setting its timeout parameter. Be sure to set timeout values or handle timeout exceptions to prevent threads from waiting for a process to end. This can lead to downtime for your customers. For more information, see CompletableFuture and Future documentation.

Suggested remediation:
Set timeout parameters for CompletableFuture.get() or Future.get().Exceptions, such as ExecutionException, InterruptedException and TimeoutException are caught and errors are logged.

@@ -59,3 +59,14 @@ - result.get(); + try { + result.get(100, TimeUnit.MILLISECONDS); + } catch (InterruptedException ie) { + log.error("Thread interrupted.", ie); + throw new InterruptedException(ie.getMessage()); + } catch (ExecutionException xe) { + log.error("The task aborted when attempting to retrieve its result.", xe); + throw new ExecutionException(xe.getMessage()); + } catch (TimeoutException te) { + log.error("Future is not done when timeout.", te); + throw new TimeoutException(te.getMessage()); + } client.close();

meyertst-aws · 2024-11-08T20:06:53Z

...be-streaming/src/main/java/com/amazonaws/transcribestreaming/TranscribeStreamingDemoApp.java

+        CompletableFuture<Void> result = client.startStreamTranscription(getRequest(16_000),
+                new AudioStreamPublisher(getStreamFromMic()),
+                getResponseHandler());
+


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It looks like you are using CompletableFuture.get() or Future.get() without setting its timeout parameter. Be sure to set timeout values or handle timeout exceptions to prevent threads from waiting for a process to end. This can lead to downtime for your customers. For more information, see CompletableFuture and Future documentation.

Suggested remediation:
Set timeout parameters for CompletableFuture.get() or Future.get().Exceptions, such as ExecutionException, InterruptedException and TimeoutException are caught and errors are logged.

@@ -42,3 +42,14 @@ - result.get(); + try { + result.get(100, TimeUnit.MILLISECONDS); + } catch (InterruptedException ie) { + log.error("Thread interrupted.", ie); + throw new InterruptedException(ie.getMessage()); + } catch (ExecutionException xe) { + log.error("The task aborted when attempting to retrieve its result.", xe); + throw new ExecutionException(xe.getMessage()); + } catch (TimeoutException te) { + log.error("Future is not done when timeout.", te); + throw new TimeoutException(te.getMessage()); + } client.close();

meyertst-aws · 2024-11-08T20:06:53Z

.../transcribe-streaming/src/main/java/com/amazonaws/transcribestreaming/StreamingRetryApp.java

+
+        /**
+         * Synchronous wait for stream to close, and close client connection
+         */


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It looks like you are using CompletableFuture.get() or Future.get() without setting its timeout parameter. Be sure to set timeout values or handle timeout exceptions to prevent threads from waiting for a process to end. This can lead to downtime for your customers. For more information, see CompletableFuture and Future documentation.

Suggested remediation:
Set timeout parameters for CompletableFuture.get() or Future.get().Exceptions, such as ExecutionException, InterruptedException and TimeoutException are caught and errors are logged.

@@ -70,3 +70,17 @@ */ - result.get(); + try { + /** + * Synchronous wait for stream to close, and close client connection + */ + result.get(100, TimeUnit.MILLISECONDS); + } catch (InterruptedException ie) { + log.error("Thread interrupted.", ie); + throw new InterruptedException(ie.getMessage()); + } catch (ExecutionException xe) { + log.error("The task aborted when attempting to retrieve its result.", xe); + throw new ExecutionException(xe.getMessage()); + } catch (TimeoutException te) { + log.error("Future is not done when timeout.", te); + throw new TimeoutException(te.getMessage()); + } client.close();

meyertst-aws · 2024-11-08T20:06:53Z

...aming/src/main/java/com/amazonaws/transcribestreaming/TranscribeMedicalStreamingDemoApp.java

+            new AudioStreamPublisher(getStreamFromMic()),
+            getMedicalResponseHandler());
+
+        result.get();


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It looks like you are using CompletableFuture.get() or Future.get() without setting its timeout parameter. Be sure to set timeout values or handle timeout exceptions to prevent threads from waiting for a process to end. This can lead to downtime for your customers. For more information, see CompletableFuture and Future documentation.

Suggested remediation:
Set timeout parameters for CompletableFuture.get() or Future.get().Exceptions, such as ExecutionException, InterruptedException and TimeoutException are caught and errors are logged.

@@ -52,3 +52,14 @@ - result.get(); + try { + result.get(100, TimeUnit.MILLISECONDS); + } catch (InterruptedException ie) { + log.error("Thread interrupted.", ie); + throw new InterruptedException(ie.getMessage()); + } catch (ExecutionException xe) { + log.error("The task aborted when attempting to retrieve its result.", xe); + throw new ExecutionException(xe.getMessage()); + } catch (TimeoutException te) { + log.error("Future is not done when timeout.", te); + throw new TimeoutException(te.getMessage()); + } client.close();

updated-readme

meyertst-aws commented Nov 6, 2024

View reviewed changes

meyertst-aws force-pushed the transcribe branch 2 times, most recently from d07e409 to a8acac3 Compare November 6, 2024 19:56

github-actions bot added the C++ This issue relates to the AWS SDK for C++ label Nov 6, 2024

meyertst-aws commented Nov 6, 2024

View reviewed changes

meyertst-aws commented Nov 8, 2024

View reviewed changes

meyertst-aws force-pushed the transcribe branch from a28526f to 97c75c6 Compare November 13, 2024 15:36

github-actions bot added GitHub settings This affects GitHub settings Tools This issue relates to a custom tooling to streamline development tasks labels Nov 13, 2024

scmacdon and others added 8 commits November 13, 2024 12:14

add a medical transcribe example

dedfadb

Fix so that transcript outputs

1065ef9

update-metadata

67097e0

fix yaml

31f4307

remove hard-coded region

e0782e8

updated-readme

fixes in response to review

0a51383

updated metadata

a1a6bf2

reorganized folder structure

c52ad86

meyertst-aws force-pushed the transcribe branch from 97c75c6 to c52ad86 Compare November 13, 2024 17:14

github-actions bot added the Ruby This issue relates to the AWS SDK for Ruby label Nov 13, 2024

Merge branch 'main' into transcribe

9014719

meyertst-aws closed this Nov 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transcribe #28

Transcribe #28

meyertst-aws commented Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 6, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

meyertst-aws Nov 8, 2024

Transcribe #28

Transcribe #28

Conversation

meyertst-aws commented Nov 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment