Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CORS support #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added CORS support #4

wants to merge 2 commits into from

Conversation

conejoninja
Copy link
Contributor

Called it CORS in the config file, but maybe it should be "allowed-origins"

Related issue #1

@conejoninja
Copy link
Contributor Author

It was already done :)

@meyskens
Copy link
Owner

Yours might be better, I didn't add the allowed hosts since in our case it is * but some might want that. Just need to check if I can add ["*"] there and it will work 😉

@meyskens meyskens reopened this Aug 17, 2017
@conejoninja
Copy link
Contributor Author

It worked on localhost, but need to test it on some server (When I have time, sorry)

@meyskens
Copy link
Owner

(Same issue here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conejoninja @meyskens