Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodeClimate and MetricFu issues #238

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix CodeClimate and MetricFu issues #238

wants to merge 6 commits into from

Conversation

vitorbaraujo
Copy link

@vitorbaraujo vitorbaraujo commented Jun 8, 2017 •
edited
Loading

  • Refactor self.task method in Processor::Collector
  • Refactor self.task method in Processor::Interpreter
  • Apply some Ruby best practices in methods above
  • Refactor metric_result_history_of method in Repository

vitorbaraujo and others added 6 commits June 1, 2017 17:28
@vitorbaraujo
Refactor task method in Processor::Interpreter
065ca7a 
This method was too big, becoming very difficult to understand
@vitorbaraujo
Apply ruby best practices on Processor::Interpreter
6c278a5
@vitorbaraujo
Refactor task method in Processor::Collector
b9a7eeb 
This refactoring decreases the cyclomatic complexity of this method
and also makes the code more understandable
@vitorbaraujo
Merge pull request #1 from vitorbaraujo/clean_code
367c995 
Improve complexity metrics in Processor module
@marceloabk
Extracting code to a method to reduce complexity
957e0fc 
Signed-off-by: Marcelo Cristiano <[email protected]>
@marceloabk
Merge pull request #2 from MES2017/clean_code_marcelo
cf44ff2 
Extract code to a method to reduce complexity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorbaraujo @marceloabk