Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing all back buttons from prezento #403

Closed
wants to merge 3 commits into from

Conversation

marceloabk
Copy link

This pull request resolve the #390 issue.

We just removed all back buttons from prezento.

We had ran all prezento tests and didn't broke any.

Signed-off-by: Marcelo Cristiano <[email protected]>
Signed-off-by: Pedro Ivo <[email protected]>
@athos-ribeiro
Copy link

Hello Marcelo,

Any comments on the failing tests on CI?

It would be nice to take a look at those.

For instance, please, take a look at the following error (which seems to be related to your changes):

When I click the Back link # features/step_definitions/user_steps.rb:1

  Unable to find link "Back" (Capybara::ElementNotFound)

  ./features/step_definitions/user_steps.rb:2:in `/^I click the (.+) link$/'

  features/repository/show/independent.feature:36:in `When I click the Back link'

Whenever you propose a patch, make sure you change the tests accordingly

marceloabk and others added 2 commits April 11, 2017 17:44
Signed-off-by: Marcelo Cristiano <[email protected]>
Signed-off-by: Pedro Ivo Andrade <[email protected]>
Signed-off-by: Pedro Ivo Andrade <[email protected]>
Signed-off-by: Marcelo Cristiano <[email protected]>
@marceloabk
Copy link
Author

Hi Athos,

When we ran the tests locally, they really passed. But in trevis build some related with our changes had broken.

We fixed those related with our changes, but trevis were still breaking with some timeout tests. So we had open another pull request that increase the time of these timeouts too.

The new pull request is #404.

@rafamanzo
Copy link
Member

Can we close this in favour of #404?

@marceloabk marceloabk closed this Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants