Correct the display of flex legs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaktack
commented
Jun 4, 2021
src/main/java/org/opentripplanner/routing/algorithm/mapping/GraphPathToItineraryMapper.java
Outdated
Show resolved
Hide resolved
…legs For Locations the coordinate is the center point of the area, not the actual place where the transition happens.
When traversing *Link edges `backMode = null`, which in most cases doesn't cause problems. When splitting Flex states, there is only a single `BUS` state, which the logic skipped. The last-seen mode is tracked, instead of the previous mode, which correct the check for mode changes.
|
I've manually tested, and it seems to work as expected. I've added a fix for another bug, wherein the
|
|
Does this address this issue? stadtnavi/digitransit-ui#571 Or this one: #92 |
|
It addresses the first one (stadtnavi/digitransit-ui#571), #92 requires updating |
|
Clarification for @hbruch: this doesn't affect the routing but only it simply places the start/end location dot to where the passenger is actually picked up/dropped off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating itineraries for flex trips:
This should fix the leg splitting mentioned in stadtnavi/digitransit-ui#571