Prefer lower ids on ties #25
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will change in the next ELKI release. It was intended to prefer lower IDs, and this "bug" (it's arbitrary, so it is not really a bug) has been fixed now. Lower ids yields more expected results. In particular, if you reorder the data set to be in cluster order, and rerun OPTICS, the result should now be stable.
|
I think the failing test needs also be updated with the new ordering if we want to include this change. |
|
ELKI 0.7.5 has been released, and now prefers lower IDs on tied distances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will change in the next ELKI release. It was intended to prefer lower IDs, and this "bug" (it's arbitrary, so it is not really a bug) has been fixed now.
Lower ids yields more expected results. In particular, if you reorder the data set to be in cluster order, and rerun OPTICS, the result should now be stable.